fix: set shortcut listener to modal only if owner is child #13272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix for #13205 moved all shortcut registration event source from UI to the modal component if one was active; this caused shortcuts owned by components not under the modal tree to also be moved if they were registered when a modal component was active, and hence they stopped working when the modal component tree was removed. This modifies the previous fix to only change the event source if the shortcut owner is under the an active modal tree.
joheriks
force-pushed
the
joheriks/fix-shortcut-on-modal-component-2
branch
from
736af20 to
4154d14
Compare
knoobie
reviewed
Mar 11, 2022
flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/ModalDialogIT.java
Outdated
Show resolved
Hide resolved
caalador
requested changes
Mar 11, 2022
flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/ModalDialogIT.java
Show resolved
Hide resolved
flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/ModalDialogIT.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Mar 11, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
The previous fix for #13205 (PR #13263) moved all shortcut registration event sources from UI to the modal component if one was active; this caused shortcuts owned by components not under the modal tree to also be moved if they were registered when a modal component was active, and hence they stopped working when the modal component tree was removed. This modifies the previous fix to only change the event source if the shortcut owner is under the an active modal tree.
joheriks
pushed a commit
that referenced
this pull request
Mar 14, 2022
…13276) The previous fix for #13205 (PR #13263) moved all shortcut registration event sources from UI to the modal component if one was active; this caused shortcuts owned by components not under the modal tree to also be moved if they were registered when a modal component was active, and hence they stopped working when the modal component tree was removed. This modifies the previous fix to only change the event source if the shortcut owner is under the an active modal tree. Co-authored-by: Johannes Eriksson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for #13205 (PR #13263) moved all shortcut
registration event sources from UI to the modal component
if one was active; this caused shortcuts owned by components
not under the modal tree to also be moved if they were registered
when a modal component was active, and hence they stopped
working when the modal component tree was removed. This
modifies the previous fix to only change the event source if the
shortcut owner is under the an active modal tree.